[PATCH] rt-tests: rt-utils: Fix potential 'debugfileprefix' overflow

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



fscanf on line 73 amounts to
fscanf(fp, "... %256s ...", debugfileprefix)

This can result in 256 characters excluding nul.

Add 1 to buffer size to accomodate a maximum write + a nul.

Signed-off-by: Ian K. Coolidge <icoolidge@xxxxxxxxxx>
---
 src/lib/rt-utils.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/lib/rt-utils.c b/src/lib/rt-utils.c
index 6c0235d..bbc0b82 100644
--- a/src/lib/rt-utils.c
+++ b/src/lib/rt-utils.c
@@ -32,7 +32,7 @@
 #define  MAX_COMMAND_LINE 4096
 #define  MAX_TS_SIZE 64
 
-static char debugfileprefix[MAX_PATH];
+static char debugfileprefix[MAX_PATH + 1];
 static char *fileprefix;
 static int trace_fd = -1;
 static int tracemark_fd = -1;
-- 
2.37.0.rc0.161.g10f37bed90-goog




[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux