On 02/05/22 11:17, John Kacur wrote: > On Tue, 19 Apr 2022, Valentin Schneider wrote: > >> Kcompile._WorkloadSetup() looks for a "tarball" and "tarfile" entry in >> the CfgSection, but I couldn't find a single setter for thoses. The >> only way for a user to specify a file is via --kcompile-source, which >> doesn't seem to be actually used by the module. >> >> As it stands, this method will look for a tarball matching the >> hardcoded kernel_prefix. >> >> Make Kcompile >> - actually use --kcompile-source >> - use the latest tarball in the loadsource if no source is specified. >> >> Signed-off-by: Valentin Schneider <vschneid@xxxxxxxxxx> >> --- >> I'm not entirely sure about that one, I tried to dig up the git >> history for uses of those "tarball" and "tarfile" options but didn't >> really get anywhere, so maybe I'm completely wrong... >> --- >> rteval/modules/loads/kcompile.py | 22 ++++++++++++++++------ >> 1 file changed, 16 insertions(+), 6 deletions(-) >> > I think we wanted to make sure we were doing an apples to apples > comparison, so we restricted the default kernel to the the one we supply > in rteval-loads. I am thinking of changing this in the future to using the > one supplied by the distribution, but still mulling this over. > > However, --kcompile-source should work as advertised. Do you think you > could resend a patch with just the part to make --kcompile-source work > correctly? > Sure thing, will do. > Thanks > > John
