Re: [PATCH 09/12] trace-cmd analyze: Add wake up latency timings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 25 Mar 2022 19:34:20 +0000
John Keeping <john@xxxxxxxxxxxx> wrote:

> > +static void process_wakeup(struct analysis_data *data,
> > +			   struct tep_handle *tep,
> > +			   struct tep_record *record)
> > +{
> > +	struct cpu_data *cpu_data = &data->cpu_data[record->cpu];
> > +	struct task_cpu_item *cpu_task;
> > +	struct task_item *task;
> > +	unsigned long long val;
> > +	int pid;
> > +
> > +	tep_read_number_field(data->wakeup_pid, record->data, &val);
> > +	pid = val;
> > +	cpu_task = get_cpu_task(cpu_data, pid);  
> 
> Should this use get_task() instead of get_cpu_task()?
> 
> I was trying this out and it provides a great overview of a trace but I
> found it strange that tasks affine to CPU N were also appearing in the
> list for CPU M.

Yes, you are correct, because I noticed the same issue :-D

I'll fix it in v2.

Thanks,

-- Steve




[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux