On 11/24/21 23:15, Steven Rostedt wrote: >>> + /* >>> + * Set the size of the bucket. >>> + */ >>> + bucket_size = params->output_divisor * params->bucket_size; >>> + snprintf(buff, sizeof(buff), "duration.buckets=%d", bucket_size); >>> + >>> + data->trace_hist = tracefs_hist_alloc(tool->trace.tep, "osnoise", "sample_threshold", >>> + buff, TRACEFS_HIST_KEY_NORMAL); >> FYI, we changed the API (haven't tagged it yet, so we can do that :-) and >> the above needs to be: >> >> data->trace_hist = tracefs_hist1d_alloc(tool->trace.tep, "osnoise", "sample_threshold", > Or do you think that 1d should be the default, and we have: > > tracefs_hist_alloc() -- 1d histogram > tracefs_hist_alloc_2d() -- 2d histogram > tracefs_hist_alloc_nd() -- Nd histogram? > > ?? IMHO, the function names in your second email sound more intuitive, i.e., tracefs_hist_alloc()/tracefs_hist_alloc_2d()/tracefs_hist_alloc_nd(). > We haven't tagged it yet, so we could change it again (and then your code > will work as is). two birds with a single stone :-) -- Daniel > -- Steve
