On 10/26/21 18:26, Steven Rostedt wrote: > On Wed, 27 Oct 2021 00:22:04 +0800 > Tao Zhou <tao.zhou@xxxxxxxxx> wrote: > >>> + do { >>> + retval = read(in_fd, buffer, sizeof(buffer)); >>> + if (read <= 0) >> check "retval" not read. Like: >> >> if (retval <= 0) > OUCH! Good check. > > Daniel, did that not produce any warnings?? OUCH OUCH! No warnings, no nothing. The code actually "works" because errors are not common and the next if stops the loop. -- Daniel > -- Steve > >