Re: [RFC 7/7] rt-tests: cyclictest: Add support to report standard deviation

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Oct 15, 2021 at 04:58:19PM +0900, Punit Agrawal wrote:
> Sure, I can bump up the version to 1.1 - minor update as it's adding a
> new field rather than changing existing ones. Or "2" if that is
> preferred.

I'd say we just increment the number to 2 and don't any semantic meaning
to the version number. Instead push the compatible checks to the user
side. I suspect many don't care anyway.

BTW, I've noticed we print the version number wrong. Currently,
'cyclictest --version' will print 'V 2.20' instead 'V 2.2'. The printf
formatting string is wrong. Same in the JSON output.  If you don't mind
you could update this well when you are updating file version
string. Thanks!

> I can look at adding support for standard deviation to the other tools
> if there's interest once the cyclictest changes have been merged.

Yeah, there a couple of tests which quite similar. So you might just
have to move the newly added code to util.h(?) and add the calls to the
tests.. It shouldn't be too difficult just a bit of repetitive
work. Probably a good starting point for an intern :)

> Thanks for taking a look.

Thanks for contributing!

Daniel



[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux