Noted. Thanks for your review. -Chao. -----Original Message----- From: John Ogness <john.ogness@xxxxxxxxxxxxx> Sent: Tuesday, July 20, 2021 10:03 PM To: Joe Perches <joe@xxxxxxxxxxx>; Qin, Chao <chao.qin@xxxxxxxxx>; linux-kernel@xxxxxxxxxxxxxxx; linux-rt-users@xxxxxxxxxxxxxxx; bigeasy@xxxxxxxxxxxxx; tglx@xxxxxxxxxxxxx; rostedt@xxxxxxxxxxx Cc: mgross@xxxxxxxxxxxxxxx; Mei, Paul <paul.mei@xxxxxxxxx>; Li, Lili <lili.li@xxxxxxxxx> Subject: Re: [PREEMPT_RT][PATCH] printk: Enhance the condition check of msleep in pr_flush() On 2021-07-20, Joe Perches <joe@xxxxxxxxxxx> wrote: > Logic continuations are typically at the end of the previous line. > And there are few too many parentheses for my taste. > > Maybe exceed 80 columns in a single line > > may_sleep = preemptible() && !in_softirq() && system_state >= > SYSTEM_RUNNING; > > or align the continuation > > may_sleep = (preemptible() && !in_softirq() && > system_state >= SYSTEM_RUNNING); > > or use individual lines > > may_sleep = (preemptible() && > !in_softirq() && > system_state >= SYSTEM_RUNNING); The kernel now has a 100-column policy, but I decided to go with this third variant for easy reading. Chao Qin, your patch will be part of the next PREEMPT_RT release. Thank you. John Ogness
