On Thu, Jan 21, 2021 at 09:50:08PM +0100, Pavel Machek wrote: > Hi! > > > I'm pleased to announce the v5.11-rc4-rt1 patch set. > > > > Changes since v5.10.8-rt24: > > > > - Updated to v5.11-rc4 > > > > Known issues > > - kdb/kgdb can easily deadlock. > > - kmsg dumpers expecting not to be called in parallel can clobber > > their temp buffer. > > - netconsole triggers WARN. > > I noticed... lot of code using in_interrupt() to decide what to do is > making it to 5.10-stable at the moment (and I guess that means > vanilla, too). > > I have recollection that that is not okay thing to do. Am I right? > Correct. These macros should not be added to new, non-core, kernel code. There's an on-going effort to clear them already, as in: - https://lkml.kernel.org/r/20201019100629.419020859@xxxxxxxxxxxxx (merged) - https://lkml.kernel.org/r/20201126132952.2287996-1-bigeasy@xxxxxxxxxxxxx (merged) - https://lkml.kernel.org/r/20210118100955.1761652-1-a.darwish@xxxxxxxxxxxxx (to be merged) > Examples: 8abec36d1274bbd5ae8f36f3658b9abb3db56c31, > d68b29584c25dbacd01ed44a3e45abb35353f1de. > That's sad. Maybe it would be wise to let a bot scan lore regularly, and send an automatic notification to authors whenever their patches reintroduce these macros to non-core kernel code. Thanks, -- Ahmed S. Darwish
