On Mon, 14 Dec 2020, Daniel Wagner wrote: > Hi John, > > On Wed, Dec 09, 2020 at 01:30:58PM -0500, John Kacur wrote: > > Incorporate the functionality of the get_cpuinfo_mhz.sh script into > > determine_maximum_mpps.sh so that get_cpuinfo_mhz.sh can be removed. > > > > Currently determine_maximum_mpps.sh (part of queuelat) asks the user > > to edit the PREAMBLE in the script to set the environment. > > > > Get rid of this by creating a menu that allows the user the set these > > variables from a menu when running the script. > > > > Here is the output from running the script with the -h option > > > > ./src/queuelat/determine_maximum_mpps.sh -h > > Usage: > > determine_maximum_mpps.sh [OPTIONS] > > > > -c cpulist > > List of processors to run on. The default is processor 0 > > Numbers are separated by commas and may include ranges. Eg. 0,3,7-11 > > Does the option also do CPU affinity. In this case I would suggest to > use '-a' to go with the pattern. > > What about long options? Long options are propably a bit harder to > implement in shell but it would be good in my opinion to keep all those > tests commands as close as possible. > > Thanks, > Daniel > > The script is using taskset to set the cpu affinity, and so it uses -c to match the option in taskset. However the script also uses taskset to run queuelat which uses -c to mean cycles-per-packet. I am fine with changing this option to -a to match cyclictest and other tests in the suite. I'll send a patch to do that. Yeah, long options are a PITA in shell script, I think I might just convert the script to python where command line options are a breeze. That will come in a later patch. John
