Re: [rt-tests v1 01/12] cyclicdeadline: Remove dead code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Wed, 18 Nov 2020, Daniel Wagner wrote:

> my_sprintf() is not used, remove it.
> 
> Signed-off-by: Daniel Wagner <dwagner@xxxxxxx>
> ---
>  compare.py                          | 12 ++++++++++++
>  src/sched_deadline/cyclicdeadline.c | 13 -------------
>  2 files changed, 12 insertions(+), 13 deletions(-)
>  create mode 100644 compare.py
> 
> diff --git a/compare.py b/compare.py
> new file mode 100644
> index 000000000000..7fb6ae818a00
> --- /dev/null
> +++ b/compare.py
> @@ -0,0 +1,12 @@
> +with open('old', 'r') as old:
> +    with open('new', 'r') as new:
> +        for ol in old.readlines():
> +            new.seek(0)
> +            for nl in new.readlines():
> +                o = ol.split()
> +                n = nl.split()
> +
> +                if o[8] == n[8]:
> +                    d = int(n[4]) - int(o[4])
> +                    p = d/int(o[4]) * 100
> +                    print('{:20} {:>8} {:>8} {:>6} {:>2.2}%'.format(o[8], o[4], n[4], d, p))
> diff --git a/src/sched_deadline/cyclicdeadline.c b/src/sched_deadline/cyclicdeadline.c
> index a6309ded3c52..e0db9669f676 100644
> --- a/src/sched_deadline/cyclicdeadline.c
> +++ b/src/sched_deadline/cyclicdeadline.c
> @@ -215,19 +215,6 @@ static int my_vsprintf(char *buf, int size, const char *fmt, va_list ap)
>  	return s - buf;
>  }
>  
> -#if 0
> -static int my_sprintf(char *buf, int size, const char *fmt, ...)
> -{
> -	va_list ap;
> -	int n;
> -
> -	va_start(ap, fmt);
> -	n = vsnprintf(buf, size, fmt, ap);
> -	va_end(ap);
> -	return n;
> -}
> -#endif
> -
>  static void ftrace_write(char *buf, const char *fmt, ...)
>  {
>  	va_list ap;
> -- 
> 2.29.2
> 
> 

Well, your git version is okay, but the version you posted here has 
compare.py, which I assume is somekind of internal tooling you created.

My SOB refers to your git version
Signed-off-by: John Kacur <jkacur@xxxxxxxxxx>



[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux