Re: [rt-tests v1 01/12] cyclicdeadline: Remove dead code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Daniel,

One comment / query below -

Daniel Wagner <dwagner@xxxxxxx> writes:

> my_sprintf() is not used, remove it.
>
> Signed-off-by: Daniel Wagner <dwagner@xxxxxxx>
> ---
>  compare.py                          | 12 ++++++++++++
>  src/sched_deadline/cyclicdeadline.c | 13 -------------
>  2 files changed, 12 insertions(+), 13 deletions(-)
>  create mode 100644 compare.py
>
> diff --git a/compare.py b/compare.py
> new file mode 100644
> index 000000000000..7fb6ae818a00
> --- /dev/null
> +++ b/compare.py
> @@ -0,0 +1,12 @@
> +with open('old', 'r') as old:
> +    with open('new', 'r') as new:
> +        for ol in old.readlines():
> +            new.seek(0)
> +            for nl in new.readlines():
> +                o = ol.split()
> +                n = nl.split()
> +
> +                if o[8] == n[8]:
> +                    d = int(n[4]) - int(o[4])
> +                    p = d/int(o[4]) * 100
> +                    print('{:20} {:>8} {:>8} {:>6} {:>2.2}%'.format(o[8], o[4], n[4], d, p))

This hunk seems to be unrelated and also not mentioned in the commit
log. Perhaps it's accidentally part of this commit?

Thanks,
Punit

[...]




[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux