On Mon, Nov 09, 2020 at 09:59:30AM +0100, Peter Zijlstra wrote: > On Fri, Nov 06, 2020 at 03:39:21PM -0500, Joe Korty wrote: > > FYI. There is one path through affine_move_task() which > > does not release the rq lock. This appears to be in error. > > > > * Either way, we really should have a @pending here. > > */ > > if (WARN_ON_ONCE(!pending)) > > return -EINVAL; > > Indeed so. I'm assuming you didn't actually hit the warning but found > this through inspection? That is correct... > Anyway, let me go ammend this. Thanks! Yer welcome! Joe