Re: [5.9.1-rt20] affine_move_task does not always release rq lock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 09, 2020 at 09:59:30AM +0100, Peter Zijlstra wrote:
> On Fri, Nov 06, 2020 at 03:39:21PM -0500, Joe Korty wrote:
> > FYI. There is one path through affine_move_task() which
> > does not release the rq lock.  This appears to be in error.
> > 
> > 	 * Either way, we really should have a @pending here.
> > 	 */
> > 	if (WARN_ON_ONCE(!pending))
> > 		return -EINVAL;
> 
> Indeed so. I'm assuming you didn't actually hit the warning but found
> this through inspection?

That is correct...

> Anyway, let me go ammend this. Thanks!

Yer welcome!
Joe



[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux