On 10/21/20 6:14 AM, Sebastian Andrzej Siewior wrote:
On 2020-10-21 14:53:27 [+0200], To Thomas Gleixner wrote:
Dear RT folks!
I'm pleased to announce the v5.9.1-rt18 patch set.
Maybe I'm doing something wrong but I get a compilation error (see
below) when trying to do a debug build (building rpm packages for
Fedora). 5.9.1 + rt19...
Builds fine otherwise...
Thanks,
-- Fernando
+ make -s 'HOSTCFLAGS=-O2 -g -pipe -Wall -Werror=format-security
-Wp,-D_FORTIFY_SOURCE=2 -Wp,-D_GLIBCXX_ASSERTIONS -fexceptions
-fstack-protector-strong -grecord-gcc-switches
-specs=/usr/lib/rpm/redhat/redhat-hardened-cc1
-specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fcommon -m64
-mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection
-fcf-protection' 'HOSTLDFLAGS=-Wl,-z,relro -Wl,--as-needed -Wl,-z,now
-specs=/usr/lib/rpm/redhat/redhat-hardened-ld' ARCH=x86_64 KCFLAGS=
WITH_GCOV=0 -j4 modules
BUILDSTDERR: In file included from <command-line>:
BUILDSTDERR: lib/test_lockup.c: In function 'test_lockup_init':
BUILDSTDERR: lib/test_lockup.c:484:31: error: 'spinlock_t' {aka 'struct
spinlock'} has no member named 'rlock'; did you mean 'lock'?
BUILDSTDERR: 484 | offsetof(spinlock_t, rlock.magic),
BUILDSTDERR: | ^~~~~
BUILDSTDERR: ././include/linux/compiler_types.h:135:57: note: in
definition of macro '__compiler_offsetof'
BUILDSTDERR: 135 | #define __compiler_offsetof(a, b)
__builtin_offsetof(a, b)
BUILDSTDERR: |
^
BUILDSTDERR: lib/test_lockup.c:484:10: note: in expansion of macro
'offsetof'
BUILDSTDERR: 484 | offsetof(spinlock_t, rlock.magic),
BUILDSTDERR: | ^~~~~~~~
BUILDSTDERR: ././include/linux/compiler_types.h:135:35: error:
'rwlock_t' {aka 'struct rt_rw_lock'} has no member named 'magic'
BUILDSTDERR: 135 | #define __compiler_offsetof(a, b)
__builtin_offsetof(a, b)
BUILDSTDERR: | ^~~~~~~~~~~~~~~~~~
BUILDSTDERR: ./include/linux/stddef.h:17:32: note: in expansion of macro
'__compiler_offsetof'
BUILDSTDERR: 17 | #define offsetof(TYPE, MEMBER)
__compiler_offsetof(TYPE, MEMBER)
BUILDSTDERR: | ^~~~~~~~~~~~~~~~~~~
BUILDSTDERR: lib/test_lockup.c:487:10: note: in expansion of macro
'offsetof'
BUILDSTDERR: 487 | offsetof(rwlock_t, magic),
BUILDSTDERR: | ^~~~~~~~
BUILDSTDERR: lib/test_lockup.c:488:10: error: 'RWLOCK_MAGIC' undeclared
(first use in this function); did you mean 'STACK_MAGIC'?
BUILDSTDERR: 488 | RWLOCK_MAGIC) ||
BUILDSTDERR: | ^~~~~~~~~~~~
BUILDSTDERR: | STACK_MAGIC
BUILDSTDERR: lib/test_lockup.c:488:10: note: each undeclared identifier
is reported only once for each function it appears in
BUILDSTDERR: In file included from <command-line>:
BUILDSTDERR: ././include/linux/compiler_types.h:135:35: error: 'struct
mutex' has no member named 'wait_lock'
BUILDSTDERR: 135 | #define __compiler_offsetof(a, b)
__builtin_offsetof(a, b)
BUILDSTDERR: | ^~~~~~~~~~~~~~~~~~
BUILDSTDERR: ./include/linux/stddef.h:17:32: note: in expansion of macro
'__compiler_offsetof'
BUILDSTDERR: 17 | #define offsetof(TYPE, MEMBER)
__compiler_offsetof(TYPE, MEMBER)
BUILDSTDERR: | ^~~~~~~~~~~~~~~~~~~
BUILDSTDERR: lib/test_lockup.c:490:10: note: in expansion of macro
'offsetof'
BUILDSTDERR: 490 | offsetof(struct mutex, wait_lock.rlock.magic),
BUILDSTDERR: | ^~~~~~~~
BUILDSTDERR: ././include/linux/compiler_types.h:135:35: error: 'struct
rw_semaphore' has no member named 'wait_lock'
BUILDSTDERR: 135 | #define __compiler_offsetof(a, b)
__builtin_offsetof(a, b)
BUILDSTDERR: | ^~~~~~~~~~~~~~~~~~
BUILDSTDERR: ./include/linux/stddef.h:17:32: note: in expansion of macro
'__compiler_offsetof'
BUILDSTDERR: 17 | #define offsetof(TYPE, MEMBER)
__compiler_offsetof(TYPE, MEMBER)
BUILDSTDERR: | ^~~~~~~~~~~~~~~~~~~
BUILDSTDERR: lib/test_lockup.c:493:10: note: in expansion of macro
'offsetof'
BUILDSTDERR: 493 | offsetof(struct rw_semaphore,
wait_lock.magic),
BUILDSTDERR: | ^~~~~~~~
BUILDSTDERR: make[1]: *** [scripts/Makefile.build:283:
lib/test_lockup.o] Error 1
BUILDSTDERR: make: *** [Makefile:1784: lib] Error 2
BUILDSTDERR: make: *** Waiting for unfinished jobs....
Changes since v5.9.1-rt17:
- Update the migrate-disable series by Peter Zijlstra to v3. Include
also fixes discussed in the thread.
- UP builds did not boot since the replace of the migrate-disable
code. Reported by Christian Egger. Fixed as a part of v3 by Peter
Zijlstra.
- Rebase the printk code on top of the ringer buffer designed for
printk which was merged in the v5.10 merge window. Patches by John
Ogness.
Known issues
- It has been pointed out that due to changes to the printk code the
internal buffer representation changed. This is only an issue if tools
like `crash' are used to extract the printk buffer from a kernel memory
image.
The delta patch against v5.9.1-rt17 is appended below and can be found here:
https://cdn.kernel.org/pub/linux/kernel/projects/rt/5.9/incr/patch-5.9.1-rt17-rt18.patch.xz
You can get this release via the git tree at:
git://git.kernel.org/pub/scm/linux/kernel/git/rt/linux-rt-devel.git v5.9.1-rt18
The RT patch against v5.9.1 can be found here:
https://cdn.kernel.org/pub/linux/kernel/projects/rt/5.9/older/patch-5.9.1-rt18.patch.xz
The split quilt queue is available at:
https://cdn.kernel.org/pub/linux/kernel/projects/rt/5.9/older/patches-5.9.1-rt18.tar.xz
The attached diff was too large and the mail was dropped. It is
available at
https://git.kernel.org/rt/linux-rt-devel/d/v5.9.1-rt18/v5.9.1-rt17
Sebastian
