Re: [PATCH 4.14-rt] Fix wrong-variable use in irq_set_affinity_notifier

[Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>]

On 2020-02-11 09:00:07 [-0500], Joe Korty wrote:
> 4.14-rt: Fix wrong-variable use in irq_set_affinity_notifier.
> 
> The bug was introduced in the 4.14-rt patch
>  
>    0461-genirq-Handle-missing-work_struct-in-irq_set_affinit.patch
> 
> The symptom is a NULL pointer panic in the i40e driver on
> system shutdown.
…
> 4.19-rt and above do not have this problem due to a refactoring.

That would be Tom's to pick. Is v4.14-RT the only one affected? I was
under the impression that we fixed it already in each stable rt tree.

> Signed-off-by: Joe Korty <Joe.Korty@xxxxxxxxxxxxxxxxx>
> 
> Index: b/kernel/irq/manage.c
> ===================================================================
> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -353,7 +353,7 @@ irq_set_affinity_notifier(unsigned int i
>  
>  	if (old_notify) {
>  #ifdef CONFIG_PREEMPT_RT_BASE
> -		kthread_cancel_work_sync(&notify->work);
> +		kthread_cancel_work_sync(&old_notify->work);
>  #else
>  		cancel_work_sync(&old_notify->work);
>  #endif

Sebastian