On Tue, 2020-02-04 at 09:35 +0000, Matt Fleming wrote: > On Mon, 03 Feb, at 07:17:46PM, Sebastian Andrzej Siewior wrote: > > On 2020-01-26 21:19:45 [+0000], Matt Fleming wrote: > > > There's no need to leave interrupts disabled when calling css_put_many(). > > > > For RT the interrupts are never actually disabled and for !RT they are > > disabled with or without the change. > > The comment about the disable function mentions just the counters and > > css_put_many()'s callback just invokes a worker so it is probably save > > to move the function as suggested. > > > > May I ask how on earth you managed to open that file on a Sunday > > evening? > > We're carrying it in some of our older SUSE RT kernels and I'd really > like to get it upstream or sent to /dev/null ;) My recollection of the reason for that patchlet existing was simply because while rummaging around one day, unlock placement offended my eye a bit, so I did a dinky on the spot correction. -Mike
