On Mon, 27 Jan 2020, Kurt Kanzenbach wrote: > Hi John, > > On Thu Jan 23 2020, John Kacur wrote: > > - Add a simple manpage for cyclicdeadline > > - Install it from the Makefile > > > > Signed-off-by: John Kacur <jkacur@xxxxxxxxxx> > > --- > > Makefile | 1 + > > src/sched_deadline/cyclicdeadline.8 | 53 +++++++++++++++++++++++++++++ > > 2 files changed, 54 insertions(+) > > create mode 100644 src/sched_deadline/cyclicdeadline.8 > > > > diff --git a/Makefile b/Makefile > > index 552b3fe885cc..e2142ba3f4e9 100644 > > --- a/Makefile > > +++ b/Makefile > > @@ -193,6 +193,7 @@ install: all install_hwlatdetect > > gzip -c src/queuelat/queuelat.8 >"$(DESTDIR)$(mandir)/man8/queuelat.8.gz" > > gzip -c src/sched_deadline/deadline_test.8 >"$(DESTDIR)$(mandir)/man8/deadline_test.8.gz" > > gzip -c src/ssdd/ssdd.8 >"$(DESTDIR)$(mandir)/man8/ssdd.8.gz" > > + gzip -c src/sched_deadline/cyclicdeadline.8 >"$(DESTDIR)$(mandir)/man8/cyclicdeadline.8.gz" > > I'm just wondering about this. Why are the man pages compressed in the > Makefile? Actually most package management systems compress the man > pages themselves. Users may want to use bz2 or something else. > > In fact, I have a patch on top of rt-tests v1.6 in Gentoo which removes > the compression, because portage complains about it. > > Thanks, > Kurt > I think it's because man pages are generally installed as .gz files on most distros. Although the Makefile is designed to work well with package management systems, it should also work correctly stand alone. If you want to submit a patch that would optionally use a different kind of compression or otherwise handle things without breaking the current defaults, I would likely accept it. John
