On Thu, 25 Jul 2019, Qiao Zhao wrote: > For current RHEL7 and RHEL8 kernel (3.10.0 and 4.18.0), we use "tracing_on" > to control tracing disable/enable. The "tracing_enabled" is not the > current value. > > For RHEL bug: https://bugzilla.redhat.com/show_bug.cgi?id=1731336 > E.g: # # svsematest -a -b 20us -f -i 100 -l 100 -S > ... > Could not access /sys/kernel/debug/tracing/tracing_enabled > > Sanity test passed. No this error msg when patched. > > Signed-off-by: Qiao Zhao <qzhao@xxxxxxxxxx> > --- > src/pmqtest/pmqtest.c | 2 +- > src/ptsematest/ptsematest.c | 2 +- > src/sigwaittest/sigwaittest.c | 2 +- > src/svsematest/svsematest.c | 2 +- > 4 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/src/pmqtest/pmqtest.c b/src/pmqtest/pmqtest.c > index 2191710..a04fc49 100644 > --- a/src/pmqtest/pmqtest.c > +++ b/src/pmqtest/pmqtest.c > @@ -204,7 +204,7 @@ void *pmqthread(void *param) > char tracing_enabled_file[MAX_PATH]; > > strcpy(tracing_enabled_file, get_debugfileprefix()); > - strcat(tracing_enabled_file, "tracing_enabled"); > + strcat(tracing_enabled_file, "tracing_on"); > int tracing_enabled = > open(tracing_enabled_file, O_WRONLY); > if (tracing_enabled >= 0) { > diff --git a/src/ptsematest/ptsematest.c b/src/ptsematest/ptsematest.c > index e8a3177..5537592 100644 > --- a/src/ptsematest/ptsematest.c > +++ b/src/ptsematest/ptsematest.c > @@ -131,7 +131,7 @@ void *semathread(void *param) > char tracing_enabled_file[MAX_PATH]; > > strcpy(tracing_enabled_file, get_debugfileprefix()); > - strcat(tracing_enabled_file, "tracing_enabled"); > + strcat(tracing_enabled_file, "tracing_on"); > int tracing_enabled = > open(tracing_enabled_file, O_WRONLY); > if (tracing_enabled >= 0) { > diff --git a/src/sigwaittest/sigwaittest.c b/src/sigwaittest/sigwaittest.c > index 4579f90..59f28a5 100644 > --- a/src/sigwaittest/sigwaittest.c > +++ b/src/sigwaittest/sigwaittest.c > @@ -179,7 +179,7 @@ void *semathread(void *param) > char tracing_enabled_file[MAX_PATH]; > > strcpy(tracing_enabled_file, get_debugfileprefix()); > - strcat(tracing_enabled_file, "tracing_enabled"); > + strcat(tracing_enabled_file, "tracing_on"); > int tracing_enabled = > open(tracing_enabled_file, O_WRONLY); > if (tracing_enabled >= 0) { > diff --git a/src/svsematest/svsematest.c b/src/svsematest/svsematest.c > index 01083d1..8f88078 100644 > --- a/src/svsematest/svsematest.c > +++ b/src/svsematest/svsematest.c > @@ -185,7 +185,7 @@ void *semathread(void *param) > char tracing_enabled_file[MAX_PATH]; > > strcpy(tracing_enabled_file, get_debugfileprefix()); > - strcat(tracing_enabled_file, "tracing_enabled"); > + strcat(tracing_enabled_file, "tracing_on"); > int tracing_enabled = > open(tracing_enabled_file, O_WRONLY); > if (tracing_enabled >= 0) { > -- Thanks for the patch I did edit the comments to remove references to rhel Signed-off-by: John Kacur <jkacur@xxxxxxxxxx>
