Re: [PATCH 3/6] rt-tests: deadline: Remove duplicated gettid() code

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Mon, 24 Jun 2019, Sebastian Andrzej Siewior wrote:

> On 2019-06-19 17:48:09 [+0200], John Kacur wrote:
> > 
> > If anyone objects because they are actively using systems that don't have 
> > gettid() in the library, please speak-up, for now this is in 
> > unstable/devel/latest-devel
> 
> ehm. gettid() is defined in
> 	src/lib/rt-utils.c
> 
> so how should someone not have that one on his system?

The sentence does say, systems that don't have gettid() in the LIBRARY.

That being said, Kurt, would like to come up with a smarter patch that 
uses the glibc version if detected else falls back on this one?

Then you need to clean it up everywhere, not just for the deadline tests.

Consider this patch NAKed for now. (it's only in the latest-devel not the 
latest version anyway)


> 
> glibc 2.30 will have gettid() [0] so maybe you could avoid using that
> one from rt-utils.c once you detect it in glibc.
> 
> [0] https://sourceware.org/git/?p=glibc.git;a=commitdiff;h=1d0fc213824eaa2a8f8c4385daaa698ee8fb7c92;hp=f289e656ec8221756519a601042bc9fbe1b310fb
> 
> >  Signed-off-by: John Kacur <jkacur@xxxxxxxxxx>
> 
> Sebastian
> 



[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux