On Wed, 19 Dec 2018 09:01:43 -0600 Tom Zanussi <zanussi@xxxxxxxxxx> wrote: > > > + if (hist_field && hist_field->var.idx == var_idx && > > > + hist_field->var.hist_data == var_data) > > > + found = hist_field; > > > > > > return found; > > > > It seems we don't need "found" var here. Just return hist_field or > > NULL. > > > > OK, will change these and resubmit shortly. Tom, If this is the only patch in the series that needs updating, can you just reply to this patch with the v2 of 3/7? That is have a subject of: [PATCH v2 3/7] tracing: Use var_refs[] for hist trigger reference checking and reply to the [PATCH 3/7] This isn't the normal way of updates, but I want to start taking this patches in ASAP, and I figured this may be the easiest for both of us. It's fine to send a v2 of the entire patch series (which other maintainers require), so I'll leave it up to you. If there's any other patch that needs changing, then a full v2 series is required. But if this is the only change and you want to send just this patch, then I'll take that as well. -- Steve
