Hi Tom,
Just a nitpick.
On Mon, 10 Dec 2018 18:01:24 -0600
Tom Zanussi <zanussi@xxxxxxxxxx> wrote:
> enum action_id {
> @@ -1961,7 +1962,8 @@ static int parse_action(char *str, struct hist_trigger_attrs *attrs)
> return ret;
>
> if ((strncmp(str, "onmatch(", strlen("onmatch(")) == 0) ||
> - (strncmp(str, "onmax(", strlen("onmax(")) == 0)) {
> + (strncmp(str, "onmax(", strlen("onmax(")) == 0) ||
> + (strncmp(str, "onchange(", strlen("onchange(")) == 0)) {
You can use sizeof() instead of strlen() for static string.
[...]
> @@ -4740,6 +4767,15 @@ static int parse_actions(struct hist_trigger_data *hist_data)
> ret = PTR_ERR(data);
> break;
> }
> + } else if (strncmp(str, "onchange(", strlen("onchange(")) == 0) {
> + char *action_str = str + strlen("onchange(");
Ditto.
Thank you,
--
Masami Hiramatsu <mhiramat@xxxxxxxxxx>
