On 11/7/18 12:10 PM, Juri Lelli wrote:
> check_dl_overrun is used to send a SIGXCPU to users that asked to be
> informed when SCHED_DEADLINE runtime overruns occur.
>
> The function is called by check_thread_timers already, so the call in
> check_process_timers is redundant/wrong (even though harmless).
>
> Remove it.
>
> Fixes: 34be39305a77 ("sched/deadline: Implement "runtime overrun signal" support")
> Signed-off-by: Juri Lelli <juri.lelli@xxxxxxxxxx>
> Cc: Peter Zijlstra <peterz@xxxxxxxxxxxxx>
> Cc: Thomas Gleixner <tglx@xxxxxxxxxxxxx>
> Cc: Luca Abeni <luca.abeni@xxxxxxxxxxxxxxx>
> Cc: Claudio Scordino <claudio@xxxxxxxxxxxxxxx>
> Cc: Mathieu Poirier <mathieu.poirier@xxxxxxxxxx>
Reviewed-by: Daniel Bristot de Oliveira <bristot@xxxxxxxxxx>
Thanks!
-- Daniel
> ---
> kernel/time/posix-cpu-timers.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/kernel/time/posix-cpu-timers.c b/kernel/time/posix-cpu-timers.c
> index ce32cf741b25..8f0644af40be 100644
> --- a/kernel/time/posix-cpu-timers.c
> +++ b/kernel/time/posix-cpu-timers.c
> @@ -917,9 +917,6 @@ static void check_process_timers(struct task_struct *tsk,
> struct task_cputime cputime;
> unsigned long soft;
>
> - if (dl_task(tsk))
> - check_dl_overrun(tsk);
> -
> /*
> * If cputimer is not running, then there are no active
> * process wide timers (POSIX 1.b, itimers, RLIMIT_CPU).
>
