Hi, On Fri, Oct 05, 2018 at 04:23:25PM +0200, Sebastian Andrzej Siewior wrote: > > It looks like __migrate_disabled was moved from linux/include/sched.h to > > linux/include/preempt.h. No problem there but for a configuration the > > inline function was transformed into a function declaration. The symbol for > > that function is not currently exported (EXPORT_SYMBOL*). > > > > Should __migrate_disabled be exported when defined in kernel/sched/core.c? > > If you need it, I guess so. In order to inline it again, it should be > moved back to sched.h… The inline nature of it, for us, is less pertinent, the symbol presence is more important. > > > And for personal knowledge: > > > > What is the reason for not using an inline function for the (CONFIG_SMP) > > && (CONFIG_PREEMPT_RT_BASE) configuration? > > we should not include sched.h (for struct task_struct) into preempt.h > > > The commit message introducing __migrate_disabled does not give much information > > regarding why it is done differently compared to 4.9-rt kernels. > > > > We will probably end up accessing the migrate_disabled field directly since we > > need to support those kernel versions somehow. > > Do you want a EXPORT_SYMBOL_GPL for that or are you good? Yes EXPORT_SYMBOL_GPL would do the trick. Thanks -- Jonathan Rajotte-Julien EfficiOS
