Re: [rfc 4.16-rt patch] arm64: efi,fpsimd: use a local_lock() in efi_virtmap_load()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 11 Jul 2018 17:07:22 +0200
Mike Galbraith <efault@xxxxxx> wrote:

> --- a/arch/arm64/kernel/fpsimd.c
> +++ b/arch/arm64/kernel/fpsimd.c
> @@ -607,8 +607,8 @@ int sve_set_vector_length(struct task_st
>  		sve_to_fpsimd(task);
>  
>  	if (task == current) {
> -		local_unlock(fpsimd_lock);
>  		local_bh_enable();
> +		local_unlock(fpsimd_lock);
>  	}
>  
>  	/*
> @@ -841,8 +841,8 @@ asmlinkage void do_sve_acc(unsigned int
>  
>  	sve_alloc(current);
>  
> -	local_bh_disable();
>  	local_lock(fpsimd_lock);
> +	local_bh_disable();
>  
>  	task_fpsimd_save();
>  	fpsimd_to_sve(current);
> @@ -854,8 +854,8 @@ asmlinkage void do_sve_acc(unsigned int
>  	if (test_and_set_thread_flag(TIF_SVE))
>  		WARN_ON(1); /* SVE access shouldn't have trapped */
>  
> -	local_unlock(fpsimd_lock);
>  	local_bh_enable();
> +	local_unlock(fpsimd_lock);
>  }
>  

We really need to have a local_lock_bh(...)

-- Steve
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux