[PATCH 05/34] cyclictest: fix signed vs unsigned compiler warnings

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



src/cyclictest/cyclictest.c: In function 'kernvar':
src/cyclictest/cyclictest.c:357:40: warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
    if (write(path, value, sizeofvalue) == sizeofvalue)
                                        ^~
src/cyclictest/cyclictest.c: In function 'raise_soft_prio':
src/cyclictest/cyclictest.c:797:59: warning: signed and unsigned type in conditional expression [-Wsign-compare]
  soft_max = (rlim.rlim_cur == RLIM_INFINITY) ? policy_max : rlim.rlim_cur;
                                                           ^
src/cyclictest/cyclictest.c:798:59: warning: signed and unsigned type in conditional expression [-Wsign-compare]
  hard_max = (rlim.rlim_max == RLIM_INFINITY) ? policy_max : rlim.rlim_max;
                                                           ^

Signed-off-by: Tommi Rantala <tommi.t.rantala@xxxxxxxxx>
---
 src/cyclictest/cyclictest.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
index 75f1fcd..4f94b06 100644
--- a/src/cyclictest/cyclictest.c
+++ b/src/cyclictest/cyclictest.c
@@ -354,7 +354,7 @@ static int kernvar(int mode, const char *name, char *value, size_t sizeofvalue)
 				value[got-1] = '\0';
 			}
 		} else if (mode == O_WRONLY) {
-			if (write(path, value, sizeofvalue) == sizeofvalue)
+			if (write(path, value, sizeofvalue) == (ssize_t)sizeofvalue)
 				retval = 0;
 		}
 		close(path);
@@ -792,8 +792,8 @@ static int raise_soft_prio(int policy, const struct sched_param *param)
 		return err;
 	}
 
-	soft_max = (rlim.rlim_cur == RLIM_INFINITY) ? policy_max : rlim.rlim_cur;
-	hard_max = (rlim.rlim_max == RLIM_INFINITY) ? policy_max : rlim.rlim_max;
+	soft_max = (rlim.rlim_cur == RLIM_INFINITY) ? policy_max : (int)rlim.rlim_cur;
+	hard_max = (rlim.rlim_max == RLIM_INFINITY) ? policy_max : (int)rlim.rlim_max;
 
 	if (prio > soft_max && prio <= hard_max) {
 		rlim.rlim_cur = prio;
-- 
2.9.3

--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux