On Tue, Nov 08, 2016 at 09:07:40AM -0500, Steven Rostedt wrote: > On Tue, 8 Nov 2016 12:59:58 +0100 > Peter Zijlstra <peterz@xxxxxxxxxxxxx> wrote: > > > No, none of this stands a chance of being accepted. > > > > This is making bad code worse. > > Peter, > > Instead of a flat out rejection, can you please provide some > constructive criticism to let those that are working on this know what > would be accepted? And what their next steps should be. > > There's obviously a problem with the current code, what steps do you > recommend to fix it? You really should already know this. As stands the current rt cgroup code (and all this throttling code) is a giant mess (as in, its not actually correct from a RT pov). We should not make it worse by adding random hacks to it. The right way to to about doing this is by replacing it with something better; like the proposed DL server for FIFO tasks -- which is entirely non-trivial as well, see existing discussion on that. I'm not entirely sure what this patch was supposed to fix, but it could be running CFS tasks with higher priority than RT for a window, instead of throttling RT tasks. This seems fairly ill specified, but something like that could easily done with an explicit or slack time DL server for CFS tasks. -- To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
