RE: [ANNOUNCE] 3.18.43-rt46

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Steven,

> Or to build 3.18.43-rt46 directly, the following patches should be applied:
> 
>   http://www.kernel.org/pub/linux/kernel/v3.x/linux-3.18.tar.xz
>   http://www.kernel.org/pub/linux/kernel/v3.x/patch-3.18.43.xz
>   http://www.kernel.org/pub/linux/kernel/projects/rt/3.18/patch-3.18.43-rt46.patch.xz
I am using the patches as proposed.

However with this version I get lots of compiler warnings:

./arch/x86/include/asm/preempt.h:118:6: warning: 'tmp' may be used uninitialized in this function [-Wmaybe-uninitialized]
  tmp &= ~PREEMPT_NEED_RESCHED;
         ^
./arch/x86/include/asm/preempt.h:112:6: note: 'tmp' was declared here
  u32 tmp;
        ^

The relevant code is the following:

/*
 * Returns true when we need to resched and can (barring IRQ state).
 */
static __always_inline bool should_resched(void)
{
#ifdef CONFIG_PREEMPT_LAZY
	u32 tmp;

	if (!raw_cpu_read_4(__preempt_count))
		return true;

	/* preempt count == 0 ? */
	tmp &= ~PREEMPT_NEED_RESCHED;
	if (tmp)
		return false;
	if (current_thread_info()->preempt_lazy_count)
		return false;
	return test_thread_flag(TIF_NEED_RESCHED_LAZY);
#else
	return unlikely(!raw_cpu_read_4(__preempt_count));
#endif
}

And within this code tmp is actually not initialized, the warning is fine.
This code is new with the patch-3.18.43-rt46.patch.xz.
With the previous patch-3.18.42-rt44.patch.xz the code of should_resched
was differently (much more compact) and did not show the warnings.

Regards

Mathias

--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux