* Josh Cartwright | 2016-03-21 09:40:16 [-0500]:
>diff --git a/include/linux/list_bl.h b/include/linux/list_bl.h
>index 44f0b55..d13428a 100644
>--- a/include/linux/list_bl.h
>+++ b/include/linux/list_bl.h
>@@ -42,13 +42,18 @@ struct hlist_bl_node {
> struct hlist_bl_node *next, **pprev;
> };
>
>-static inline void INIT_HLIST_BL_HEAD(struct hlist_bl_head *h)
>-{
>- h->first = NULL;
> #ifdef CONFIG_PREEMPT_RT_BASE
>- raw_spin_lock_init(&h->lock);
>+#define INIT_HLIST_BL_HEAD(h) \
>+do { \
>+ (h)->first = NULL; \
>+ raw_spin_lock_init(&(h)->lock); \
>+} while (0)
>+#else
>+#define INIT_HLIST_BL_HEAD(h) \
>+do { \
>+ (h)->first = NULL; \
>+} while (0)
> #endif
>-}
So we use a macro instead a "static inline" to ensure we end up with
another lockdep class? This surprises me because it would mean that the
function wasn't inlined / key classed was re-used.
Looking at the assembly I see:
|ffffffff8121fb41: 48 c7 c2 e0 bb d6 82 mov $0xffffffff82d6bbe0,%rdx
|ffffffff8121fb48: 48 89 df mov %rbx,%rdi
|ffffffff8121fb4b: 48 c7 c6 30 2b a2 81 mov $0xffffffff81a22b30,%rsi
|ffffffff8121fb52: e8 a9 0e e9 ff callq ffffffff810b0a00 <__raw_spin_lock_init>
…
|ffffffff8121fc12: 48 c7 c2 d0 bb d6 82 mov $0xffffffff82d6bbd0,%rdx
|ffffffff8121fc19: 48 c7 c6 7b 2e a3 81 mov $0xffffffff81a32e7b,%rsi
|ffffffff8121fc20: 48 c7 07 00 00 00 00 movq $0x0,(%rdi)
|ffffffff8121fc27: 48 83 c7 08 add $0x8,%rdi
|ffffffff8121fc2b: e8 d0 0d e9 ff callq ffffffff810b0a00 <__raw_spin_lock_init>
rdx holds the third parameter and it is different. What do I miss?
Was the rdx argument in Luis' case the same before this path was
applied?
Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
