Re: [rfc patch v4.4-rt2] sched: fix up preempt lazy forward port

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/25/2016 06:14 PM, Grygorii Strashko wrote:

>> diff --git a/arch/arm/kernel/entry-common.S
>> b/arch/arm/kernel/entry-common.S
>> index 30a7228eaceb..c3bd6cbfce4b 100644
>> --- a/arch/arm/kernel/entry-common.S
>> +++ b/arch/arm/kernel/entry-common.S
>> @@ -36,7 +36,9 @@
>>    UNWIND(.cantunwind    )
>>       disable_irq_notrace            @ disable interrupts
>>       ldr    r1, [tsk, #TI_FLAGS]        @ re-check for syscall tracing
>> -    tst    r1, #_TIF_SYSCALL_WORK | _TIF_WORK_MASK
>> +    tst    r1, #((_TIF_SYSCALL_WORK | _TIF_WORK_MASK) & ~_TIF_SECCOMP)
>> +    bne    fast_work_pending
>         ^^^^^^^^^^^^^^^^
> 
>> +    tst    r1, #_TIF_SECCOMP
>>       bne    fast_work_pending
>         ^^^^^^^^^^^^^^^^^
> 
> Should it be "fast_work_pending" in both cases?

Yes, I think so and it is, isn't it?
The original is

     tst    r1, #_TIF_SYSCALL_WORK | _TIF_WORK_MASK
     bne    fast_work_pending

and with the LAZY bits in it, the ASM opcode no longer works because
the constant is too large (or has to many bits set). So I removed the
_TIF_SECCOMP bit out of the mask and made two compare & jumps here.

Sebastian

--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux