Re: [PATCH rt-tests 5/9] cyclictest: use correct type when allocating cpu bitmask size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Mon, 31 Aug 2015, Josh Cartwright wrote:

> On any sane platform sizeof(long) == sizeof(unsigned long), so this
> does not actually fix a real bug, but the code should at least be
> consistent.
> 
> Signed-off-by: Josh Cartwright <joshc@xxxxxx>
> ---
>  src/cyclictest/rt_numa.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/cyclictest/rt_numa.h b/src/cyclictest/rt_numa.h
> index caa80e6..9da9fd8 100644
> --- a/src/cyclictest/rt_numa.h
> +++ b/src/cyclictest/rt_numa.h
> @@ -229,7 +229,7 @@ static inline struct bitmask* rt_numa_parse_cpustring(const char* s,
>  			 * max_cpus bits */
>  			int nlongs = (max_cpus+BITS_PER_LONG-1)/BITS_PER_LONG;
>  
> -			mask->maskp = calloc(nlongs, sizeof(long));
> +			mask->maskp = calloc(nlongs, sizeof(unsigned long));
>  			if (mask->maskp) {
>  				mask->maskp[cpu/BITS_PER_LONG] |=
>  					(1UL << (cpu % BITS_PER_LONG));
> -- 
> 2.5.0
> 
> --

Suspect this isn't the only inconsistency here between longs and unsigned 
longs, but
Signed-off-by: John Kacur <jkacur@xxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux