On Tue, 14 Jul 2015, Sebastian Andrzej Siewior wrote: > * John Kacur | 2015-07-10 14:25:30 [+0200]: > > >Adding _STRING doesn't add any extra meaning, but the extra length makes > >the Makefile more unreadable than is necessary, so shorten this up > > It isn't a STRING to begin with. You could use __stringify() to make a > string out of it. Not sure if -D=\"VERSION\" works as expected. This That does look a little bogus doesn't it? will need to take a closer look. > would also get rid of the "overflow" with 0.100 that was mentioned in > the thread… > > >diff --git a/Makefile b/Makefile > >index a48e7597b908..1f7640b82fa6 100644 > >--- a/Makefile > >+++ b/Makefile > >@@ -158,23 +158,23 @@ release: distclean changelog > > mkdir -p releases > > mkdir -p tmp/rt-tests > > cp -r Makefile COPYING ChangeLog MAINTAINERS doc README.markdown src tmp/rt-tests > >- rm -f rt-tests-$(VERSION_STRING).tar rt-tests-$(VERSION_STRING).tar.asc > >- tar -C tmp -cf rt-tests-$(VERSION_STRING).tar rt-tests > >- gpg2 --default-key clrkwllms@xxxxxxxxxx --detach-sign --armor rt-tests-$(VERSION_STRING).tar > >- gzip rt-tests-$(VERSION_STRING).tar > >+ rm -f rt-tests-$(VERSION).tar rt-tests-$(VERSION).tar.asc > >+ tar -C tmp -cf rt-tests-$(VERSION).tar rt-tests > >+ gpg2 --default-key clrkwllms@xxxxxxxxxx --detach-sign --armor rt-tests-$(VERSION).tar > >+ gzip rt-tests-$(VERSION).tar > > rm -f ChangeLog > >- cp rt-tests-$(VERSION_STRING).tar.gz rt-tests-$(VERSION_STRING).tar.asc releases > >+ cp rt-tests-$(VERSION).tar.gz rt-tests-$(VERSION).tar.asc releases > > Is this target in use? I doubt you use Clark's key. You could remove the > --default-key option and have default-key in ~/.gnupg/gpg.conf. > Oh, I like that idea, will have a closer look. Thanks John
