Re: [PATCH V2 RESEND 1/1] Clocksource: Add sched_clock to Atmel TCB clocksource

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



* Carsten Emde | 2015-06-03 00:08:05 [+0200]:

>@@ -339,6 +346,10 @@ static int __init tcb_clksrc_init(void)
> 	if (ret)
> 		goto err_disable_t1;
>
>+	local_irq_save(flags);
>+	sched_clock_register(sched_clock_get_cycles, 32, divided_rate);
>+	local_irq_restore(flags);

The other sched_clock_register() users don't do this and are invoked via
CLOCKSOURCE_OF_DECLARE / clocksource_of_init() and this is probably
early enough so the irqs stay off.
Since this is not -RT specific at all, do you mind routing it via ARM/
clocksource folks? They also may have an idea what is stopping them from
using clocksource_of_init() so you wouldn't have to disable interrupts
here.

> 	/* channel 2:  periodic and oneshot timer support */
> 	ret = setup_clkevents(tc, clk32k_divisor_idx);
> 	if (ret)

Sebastian
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux