Re: [RFC][PATCH v3] sched/rt: Use IPI to trigger RT task push migration instead of pulling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 25 Feb 2015 22:26:44 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> +static int find_next_push_cpu(struct rq *rq)
> +{
> +	struct rq *next_rq;
> +	int cpu;
> +
> +	while (1) {
> +		cpu = rto_next_cpu(rq);
> +		if (cpu >= nr_cpu_ids)
> +			break;
> +		next_rq = cpu_rq(cpu);
> +
> +		/* Make sure the next rq can push to this rq */
> +		if (next_rq->rt.highest_prio.next <
> +		    rq->rt.highest_prio.curr &&

> +		    next_rq->rt.highest_prio.next <
> +		    rq->rt.highest_prio.next)

OK, this second comparison is not needed. I was looking at the code in
more detail, and see that the .curr is updated when a new task is
enqueued, and it does not represent the task currently running, but the
highest priority task that is on the rq.

I'll be sending a v4 soon with this update.

-- Steve

> +			break;
> +	}
> +
> +	return cpu;
> +}
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux