Re: [RFC][PATCH v2] sched/rt: Use IPI to trigger RT task push migration instead of pulling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 24 Feb 2015 13:39:46 -0500
Steven Rostedt <rostedt@xxxxxxxxxxx> wrote:

> @@ -1775,6 +1946,15 @@ static int pull_rt_task(struct rq *this_
>  	 */
>  	smp_rmb();
>  
> +	/* Use local just in case a feature is switched in the middle of this */
> +	if ((use_ipi = sched_feat(RT_PUSH_IPI))) {
> +		/* Make sure the update to pending is visible here. */
> +		smp_rmb();

While porting this to the -rt kernel, I noticed that this rmb is
unneeded. It's already called above for a different reason :-p

-- Steve

> +
> +		/* If a push ipi is out, then we must do the old method */
> +		push_pending = READ_ONCE(this_rq->rt.push_csd_pending);
> +	}
> +
>  	for_each_cpu(cpu, this_rq->rd->rto_mask) {
>  		if (this_cpu == cpu)
>  			continue;
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux