Re: [RFC PATCH] rt/aio: fix rcu garbage collection might_sleep() splat

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



09.06.2014 10:22, Mike Galbraith пишет:
On Mon, 2014-06-09 at 05:17 +0200, Mike Galbraith wrote:
On Mon, 2014-06-09 at 10:08 +0800, Lai Jiangshan wrote:
Hi, rt-people

@@ -522,7 +524,9 @@ static void free_ioctx_users(struct perc
  	struct kioctx *ctx = container_of(ref, struct kioctx, users);
  	struct kiocb *req;

+	preempt_enable_rt();
  	spin_lock_irq(&ctx->ctx_lock);
+	local_irq_disable_rt();

  	while (!list_empty(&ctx->active_reqs)) {
  		req = list_first_entry(&ctx->active_reqs,
@@ -536,6 +540,8 @@ static void free_ioctx_users(struct perc

  	percpu_ref_kill(&ctx->reqs);
  	percpu_ref_put(&ctx->reqs);
+	preempt_disable_rt();
+	local_irq_enable_rt();


I think, enable_/disable_ must be as mirror reflections


    preempt_enable_rt();
        local_irq_disable_rt();

                do_something();

        local_irq_enable_rt();
    preempt_disable_rt();



--

                                                         Pavel.
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux