On Wed, 2014-04-30 at 11:11 -0400, Steven Rostedt wrote:
> > Another little bug. This hunk of patches/stomp-machine-raw-lock.patch
> > should be while (atomic_read(&done.nr_todo))
> >
> > @@ -647,7 +671,7 @@ int stop_machine_from_inactive_cpu(int (
> > ret = multi_cpu_stop(&msdata);
> >
> > /* Busy wait for completion. */
> > - while (!completion_done(&done.completion))
> > + while (!atomic_read(&done.nr_todo))
^--- that ! needs to go away
>
> I don't see this in the code. That is, there is no "completion_done()"
> in stop_machine_from_inactive_cpu(). It is already an atomic_read().
Yes, but it should read "while (atomic_read(&done.nr_todo))"
-Mike
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
