On 03/07/2014 02:36 PM, Stanislav Meduna wrote: > On 07.03.2014 09:46, Marc Kleine-Budde wrote: > >> Adding the linux-can mailinglist to Cc. > > I am not subscribed so maybe that's why the original mail > did not get through - I did Cc: linux-can@xxxxxxxxxxxxxxx > >> Your kernel is missing the patch: >> >> e358784 can: flexcan: fix mx28 detection by rearanging OF match table >> >> With this patch the CAN core properly detected as an mx28, so that bus >> errors stay disabled (unless you enable them). If you need bus errors to >> detect not connected CAN busses, you need another patchset berr_limit, >> which is not yet mainline. I can repost it here, if you need it. > > Ah ok. > > Thank you, this probably points me to the right direction - I'll try > to implement this behaviour in my kernel (unfortunately > I cannot move to more recent one at the moment). The following hack should fix the problem: diff --git a/drivers/net/can/flexcan.c b/drivers/net/can/flexcan.c index eb4014a..a6be018 100644 --- a/drivers/net/can/flexcan.c +++ b/drivers/net/can/flexcan.c @@ -727,7 +727,16 @@ static int flexcan_chip_start(struct net_device *dev) reg_ctrl = flexcan_read(®s->ctrl); reg_ctrl &= ~FLEXCAN_CTRL_TSYN; reg_ctrl |= FLEXCAN_CTRL_BOFF_REC | FLEXCAN_CTRL_LBUF | - FLEXCAN_CTRL_ERR_STATE | FLEXCAN_CTRL_ERR_MSK; + FLEXCAN_CTRL_ERR_STATE; + + /* + * Quick and dirty hack to enable the "error interrupt" + * (FLEXCAN_CTRL_ERR_MSK) for the i.MX8. Warning: this + * does not work on most other Flexcan cores. There, we + * then don't get any error warning or passive interrupts. + */ + if (priv->can.ctrlmode & CAN_CTRLMODE_BERR_REPORTING) + reg_ctrl |= FLEXCAN_CTRL_ERR_MSK; /* save for later use */ priv->reg_ctrl_default = reg_ctrl; Anyway, you should check if there are other important improvement and fixes a pending. Wolfgang. -- To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
