Re: rt-tests: make rpm fails if numactl-devel is missing

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 02/08/13 16:49, Sven-Thorsten Dietrich wrote:
> 
> On Feb 8, 2013, at 3:03 PM, Frank Rowand <frank.rowand@xxxxxxxxxxx> wrote:
> 
>> Hi all,
>>
>> I'm not sure what the best solution for this is.  Or if it is even
>> worth fixing.  So just reporting for the archives...
>>
>> rt-tests can be built without NUMA:
>>
>>   make NUMA=0
>>
>> But "make rpm" does not have a way to be successful without NUMA:
> 
> I ran into this in the past with OBS on Suse.
> 
> There was a tertiary issue, because some distros use i386
> and others use i586 or i686.
> 
> E.g.
> 
> [sven@www rt-tests]$ gcc -dumpmachine
> i586-suse-linux
> 
> diff --git a/Makefile b/Makefile
> index 3a82407..7bb022c 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -16,7 +16,7 @@ srcdir        ?= $(prefix)/src
>  
>  machinetype = $(shell $(CC) -dumpmachine | \
>      sed -e 's/-.*//' -e 's/i.86/i386/' -e 's/mips.*/mips/' -e 's/ppc.*/powerpc/')
> -ifneq ($(filter x86_64 i386 ia64 mips powerpc,$(machinetype)),)
> +ifneq ($(filter x86_64 i586 ia64 mips powerpc,$(machinetype)),)
>  NUMA   := 1
>  endif
> 
> So all in all, this feature probably only works on some, and maybe needs to be worked around more often than not.
> 
> Sven

OK, that prodded me enough to create an ugly patch, which will be following
in another email.

-Frank


--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux