On 12/17/12 10:24, Bhavesh Davda wrote: >>> I'm going to respond to your proposed patch next. >>> >>> Thanks >>> >>> - Bhavesh >> >> ping.... >> >> Thanks, >> >> Frank > > Hello Frank, > > Extremely sorry about the tardiness in reviewing your proposed > change! No problem. Life is busy, we progress as we can. > Your change looks good to me. Again, did you want me to fold your > proposed change into my original patch, or were you proposing > applying your patch (of course without the #if 0's) on top of mine? It would be great if you could add my changes on top of your original patch since John hasn't committed your original patch yet. That way everything will be coordinated from one person. And yes, without the "#if 0's". It would probably be good to submit it to John as a series of two patches, your original patch, followed by my additions. For my patch, you can add: Signed-off-by: Frank Rowand <frank.rowand@xxxxxxxxxxx> My patch did not address one other comment I made, which is: default of -g to zero means histogram overflows will be printed even if "-g" not specified (same as "-g 0"). The output of histogram overflows should only occur if of_max > 0. > Thanks for spending so much time reviewing my patches, trying them > out, and suggesting ways to make it better! Your welcome! -Frank -- To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
