Re: Don't reference non-standard realtime group

[Clark Williams <williams@xxxxxxxxxx>]

On Thu, 18 Oct 2012 11:13:21 -0500
Josh Cartwright <josh.cartwright@xxxxxx> wrote:

> On Tue, Oct 16, 2012 at 01:13:35AM +0200, John Kacur wrote:
> > 
> > 
> > On Sun, 2 Sep 2012, Uwe Kleine-König wrote:
> > 
> > > On Wed, Jul 13, 2011 at 10:48:31PM +0200, Uwe Kleine-König wrote:
> > > > There is no dedicated realtime group in most distributions. So make the
> > > > error message a bit more understandable for people not running Redhat
> > > > MRG.
> > 
> > I thought we rejected this (via irc) the first time you sent it. The idea 
> > of a realtime group is pretty generic, but sure, it isn't there by default 
> > if you don't create it. However, the worse thing about this patch is that 
> > your message is in no way clearer than the original. It's longer though.
> 
> How do you feel about this wording?
> 
> Signed-off-by: Josh Cartwright <josh.cartwright@xxxxxx>
> 
> diff --git a/src/lib/rt-utils.c b/src/lib/rt-utils.c
> index f4da4b3..e799c15 100644
> --- a/src/lib/rt-utils.c
> +++ b/src/lib/rt-utils.c
> @@ -264,8 +264,11 @@ int check_privs(void)
>  	/* try to change to SCHED_FIFO */
>  	param.sched_priority = 1;
>  	if (sched_setscheduler(0, SCHED_FIFO, &param)) {
> -		fprintf(stderr, "Unable to change scheduling policy!\n");
> -		fprintf(stderr, "either run as root or join realtime group\n");
> +		fprintf(stderr, "Unable to change scheduling policy.\n");
> +		fprintf(stderr, "This likely means you lack real-time privileges.\n");
> +		fprintf(stderr, "It may be necessary to run as root or create/join a 'realtime' group.\n");
> +		fprintf(stderr, "More details at the RTWiki:\n");
> +		fprintf(stderr, "https://rt.wiki.kernel.org/index.php/Frequently_Asked_Questions\n";);
>  		return 1;
>  	}
>  

I'm good with this.

Clark

Attachment: signature.asc
Description: PGP signature