On Tue, Oct 16, 2012 at 01:13:35AM +0200, John Kacur wrote: > On Sun, 2 Sep 2012, Uwe Kleine-König wrote: > > > On Wed, Jul 13, 2011 at 10:48:31PM +0200, Uwe Kleine-König wrote: > > > There is no dedicated realtime group in most distributions. So make the > > > error message a bit more understandable for people not running Redhat > > > MRG. > > I thought we rejected this (via irc) the first time you sent it. The idea > of a realtime group is pretty generic, but sure, it isn't there by default > if you don't create it. However, the worse thing about this patch is that > your message is in no way clearer than the original. It's longer though. FWIW, our systems also lack a 'realtime' group, so the existing error message can lead to a WTF for our users. At least mentioning RLIMIT_RTPRIO provides a googlable keyword for those newbie users who may not know what it means. It looks like Debian's been carrying Uwe's patch for about a year now. A downstream distribution patching a specific message into a generic one seems like an inversion to me. Shouldn't upstream contain the most generic message, and downstream distributors patch to make them more specific? Josh > Sorry, I don't like it, maybe Clark will overrule me if he's bored, or > cares enough, but I'm not putting it in. > > > > > > > Signed-off-by: Uwe Kleine-König <u.kleine-koenig@xxxxxxxxxxxxxx> > > > Closes: http://bugs.debian.org/619938 > > ping?! > > > > > --- > > > src/lib/rt-utils.c | 3 ++- > > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > > > --- a/src/lib/rt-utils.c > > > +++ b/src/lib/rt-utils.c > > > @@ -72,7 +72,8 @@ > > > param.sched_priority = 1; > > > if (sched_setscheduler(0, SCHED_FIFO, ¶m)) { > > > fprintf(stderr, "Unable to change scheduling policy!\n"); > > > - fprintf(stderr, "either run as root or join realtime group\n"); > > > + fprintf(stderr, "Probably missing capabilities, either run as " > > > + "root or increase RLIMIT_RTPRIO limits.\n"); > > > return 1; > > > }
Attachment:
pgprZnShtmOBI.pgp
Description: PGP signature
