Re: [PATCH RT 3/4] mips-remove-smp-reserve-lock.patch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 06/07/2012 08:51 AM, Steven Rostedt wrote:
From: Thomas Gleixner<tglx@xxxxxxxxxxxxx>

Instead of making the lock raw, remove it as it protects nothing.

I don't know how you guys are managing the RT branch, but this seems quite similar to:

a3c8b4faeeccb33dbad6969bc9e50bf409f167e7 (MIPS: Cavium: Remove smp_reserve_lock.)

David Daney



Signed-off-by: Thomas Gleixner<tglx@xxxxxxxxxxxxx>
Cc: stable-rt@xxxxxxxxxxxxxxx
Signed-off-by: Steven Rostedt<rostedt@xxxxxxxxxxx>
---
  arch/mips/cavium-octeon/smp.c |    6 ------
  1 file changed, 6 deletions(-)

diff --git a/arch/mips/cavium-octeon/smp.c b/arch/mips/cavium-octeon/smp.c
index efcfff4..86fce15 100644
--- a/arch/mips/cavium-octeon/smp.c
+++ b/arch/mips/cavium-octeon/smp.c
@@ -257,8 +257,6 @@ DEFINE_PER_CPU(int, cpu_state);

  extern void fixup_irqs(void);

-static DEFINE_SPINLOCK(smp_reserve_lock);
-
  static int octeon_cpu_disable(void)
  {
  	unsigned int cpu = smp_processor_id();
@@ -266,8 +264,6 @@ static int octeon_cpu_disable(void)
  	if (cpu == 0)
  		return -EBUSY;

-	spin_lock(&smp_reserve_lock);
-
  	cpu_clear(cpu, cpu_online_map);
  	cpu_clear(cpu, cpu_callin_map);
  	local_irq_disable();
@@ -277,8 +273,6 @@ static int octeon_cpu_disable(void)
  	flush_cache_all();
  	local_flush_tlb_all();

-	spin_unlock(&smp_reserve_lock);
-
  	return 0;
  }


--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux