On Fri, May 4, 2012 at 12:37 AM, John Kacur <jkacur@xxxxxxxxxx> wrote:
>
>
> On Thu, 3 May 2012, Clark Williams wrote:
>
>> On Thu, 03 May 2012 14:13:56 -0700
>> Darren Hart <dvhart@xxxxxxxxxxxxxxx> wrote:
>>
>> >
>> >
>> > On 05/03/2012 12:48 PM, Frank Rowand wrote:
>> > >
>> > > V2: use type casting instead of ugly constant in format string
>> > >
>> > >
>> > > Fix printf format string to fix compile warning for ARM 32 bit target.
>> > >
>> >
>> > Oh much better. :-)
>> >
>> > > Signed-off-by: Frank Rowand <frank.rowand@xxxxxxxxxxx>
>> > > ---
>> > > src/cyclictest/cyclictest.c | 2 1 + 1 - 0 !
>> > > 1 file changed, 1 insertion(+), 1 deletion(-)
>> > >
>> > > Index: b/src/cyclictest/cyclictest.c
>> > > ===================================================================
>> > > --- a/src/cyclictest/cyclictest.c
>> > > +++ b/src/cyclictest/cyclictest.c
>> > > @@ -1575,7 +1575,7 @@ int main(int argc, char **argv)
>> > > print_tids(parameters, num_threads);
>> > > if (break_thread_id) {
>> > > printf("# Break thread: %d\n", break_thread_id);
>> > > - printf("# Break value: %lu\n", break_thread_value);
>> > > + printf("# Break value: %llu\n", (unsigned long long)break_thread_value);
>> > > }
>> > > }
>> > >
>> > >
>> >
>> >
>>
>> Yes, I like this better. I pulled the original and applied this.
>
> Well, I really hate the C99 macros too, they're uglier than sin. But, you
> want to fix a compiler error on 32-bit by creating one on 64-bits? What
> are you guys smoking?
>
> NAK
>
> The above patch creates the following error on 64-bit
> src/cyclictest/cyclictest.c:1564:4: warning: format ‘%llu’ expects
> argument of type ‘long long unsigned int’, but argument 2 has type
> ‘uint64_t’ [-Wformat]
Ok, obviously, it's me who must have been smoking something. My bad, my bad.
there is a cast in there.
That patch is way better, sorry. I approve!
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
