Re: [PATCH 3/3] rt-tests: Remove unused status variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 20, 2012 at 8:05 PM, Darren Hart <dvhart@xxxxxxxxxxxxxxx> wrote:
> The status variable is not used. Remove it and avoid the warning from gcc.
>
> Signed-off-by: Darren Hart <dvhart@xxxxxxxxxxxxxxx>
> CC: Clark Williams <williams@xxxxxxxxxx>
> CC: John Kacur <jkacur@xxxxxxxxxx>
> ---
>  src/pi_tests/pi_stress.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
>
> diff --git a/src/pi_tests/pi_stress.c b/src/pi_tests/pi_stress.c
> index 0940567..b89dec8 100644
> --- a/src/pi_tests/pi_stress.c
> +++ b/src/pi_tests/pi_stress.c
> @@ -596,10 +596,9 @@ void *reporter(void *arg)
>
>  int verify_cpu(int cpu)
>  {
> -       int status;
>        cpu_set_t mask;
>
> -       status = sched_getaffinity(0, sizeof(cpu_set_t), &mask);
> +       sched_getaffinity(0, sizeof(cpu_set_t), &mask);
>
>        if (CPU_ISSET(cpu, &mask))
>                return SUCCESS;
> --

Don't you think it would be smarter to test the return status of
sched_getaffinity, than to shut-up the warning by removing the status
variable? I say we leave the variable in to remind us that we're not
finished.

Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux