On Thu, Mar 10, 2011 at 5:26 AM, John Kacur <jkacur@xxxxxxxxxx> wrote:
>
>
> On Wed, Mar 9, 2011 at 4:30 PM, Carsten Emde <C.Emde@xxxxxxxxx> wrote:
>>
>> On 03/09/2011 04:08 PM, Geunsik Lim wrote:
>>>
>>> When we try to run ftrace with cyclictest command of rt-test,
>>> We view the error according to base kernel version.
>>> We need to modify this hard coded interface.
>>>
>>> Signed-off-by: Geunsik Lim<geunsik.lim@xxxxxxxxxxx>
>>
>> We need a space here: Geunsik Lim <geunsik.lim@xxxxxxxxxxx>
>>
>>> ---
>>> Âsrc/cyclictest/cyclictest.c | Â Â3 ++-
>>> Â1 files changed, 2 insertions(+), 1 deletions(-)
>>
>> Oops, this is still old, it's only 1 insertion now. You could have
>> produced a real patch, couldn't you?
>>
>>> diff --git a/src/cyclictest/cyclictest.c b/src/cyclictest/cyclictest.c
>>> index 0847aed..abc0b4e 100644
>>> --- a/src/cyclictest/cyclictest.c
>>> +++ b/src/cyclictest/cyclictest.c
>>> @@ -487,7 +487,7 @@ static void setup_tracer(void)
>>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Âsetkernvar(traceroptions, traceptr[i]);
>>> Â Â Â Â Â Â Â Â}
>>> Â Â Â Â Â Â Â Âsetkernvar("tracing_max_latency", "0");
>>> - Â Â Â Â Â Â Â setkernvar("latency_hist/wakeup_latency/reset", "1");
>>> + Â Â Â Â Â Â Â setkernvar("latency_hist/wakeup/reset", "1");
>>> Â Â Â Â} else {
>>> Â Â Â Â Â Â Â Âsetkernvar("trace_all_cpus", "1");
>>> Â Â Â Â Â Â Â Âsetkernvar("trace_freerunning", "1");
>>
>> Acked-by: Carsten Emde <C.Emde@xxxxxxxxx>
>
> Did it used to be wakeup_latency in an older version that we still need to
> support?
At first, I sent patch file to support both old version(e.g: 2.6.24
and current version(e.g: 2.6.33)
And then, I resent this patch file after update according to the
review of Carsten Emde.
> This is not correct - probably an unintended insertion of the line that was removed abov
At that time, I think that We,may support latest Linux version. So, I
agreed with
Carsten's review. But, I understood incorrectly the reply of Carsten Emde about
my initial patch content.
Belows is wakeup interface per each Linus version. I summarized to understand
the goal of original patch file.
2.6.24.7-rt23 /sys/kernel/debug/tracing/latency_hist/wakeup_latency/reset
2.6.31-rc9-rt9.1 /sys/kernel/debug/tracing/latency_hist/wakeup/reset
2.6.33.7.2-rt30 /sys/kernel/debug/tracing/latency_hist/wakeup/reset
John. You are right. In my case, I am using RHEL5-MRG(2.6.24) and
RHEL6(2.6.32).
We have to support for software compatibility both previous Linux version
and current Linux version.
John, Please, apply the previous original patch.
Or If Carsten Emde agree with this explanation for consensus,
I will resend the original patch including additional reviewers like
John , Carsten
file.
--
Regards,
Geunsik Lim ( Samsung Electronics )
Blog : http://blog.naver.com/invain/
e-Mail: geunsik.lim@xxxxxxxxxxx
    Â leemgs@xxxxxxxxx , leemgs1@xxxxxxxxx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
