John, > [..] I'll be posting some more tomorrow. Okay, great. I have found an issue with all source files of the new tests. At some stage between the original files and Clark's tree, the line delimiters changed from NL to CR/NL. Would be great, if you could move this back to NL. A second issue is related to the removal of the getcpu() definition. There is a leftover in svsematest.c which should also be removed for consistency. However, this and the other tests no longer compile in EL5 without this definition - should we better revert this and provide a working recognition through "grep sched_getcpu /usr/include/bits/sched.h"? Or is EL5 irrelevant in this context? I still have an EL5 test machine where all RT kernels are tested. Another issue is in the file backfire.c After you removed the line >> - sed s/__VERSION_STRING__/$(VERSION_STRING)/ [..] from the Makefile, the driver is producing the rather ugly syslog message: backfire driver v__VERSION_STRING__ instead of backfire driver v0.57 or similar. We better completely remove the version display. Signed-off-by: Carsten Emde <C.Emde@xxxxxxxxx>
--- backfire.c-orig 2009-12-20 22:40:48.000000000 +0100 +++ backfire.c 2009-12-20 22:41:40.000000000 +0100 @@ -132,7 +132,7 @@ if (ret) printk(KERN_ERR "backfire: can't register dynamic misc device\n"); else - printk(KERN_INFO "backfire driver v__VERSION_STRING__ misc device %d\n", + printk(KERN_INFO "backfire driver misc device %d\n", backfire_dev.minor); return ret; }
