On Mon, Sep 29, 2008 at 4:10 AM, John Kacur <jkacur@xxxxxxxxx> wrote: > If you start with the real-time kernel linux-2.6.26.5-rt9 and > configure it to disable CONFIG_PREEMPT_RT, for example > CONFIG_PREEMPT_DESKTOP=y > # CONFIG_PREEMPT_RT is not set > > you will get the following compile error on 32-bit i386. (actually, > this will happen on any platform that doesn't use > CONFIG_RWSEM_GENERIC_SPINLOCK) [...] > include/linux/rwsem.h:149: error: redefinition of 'rwsem_is_locked' > include/asm/rwsem.h:261: error: previous definition of > 'rwsem_is_locked' was here > include/linux/rwsem.h: In function 'rwsem_is_locked': > include/linux/rwsem.h:151: error: implicit declaration of function > 'compat_rwsem_is_locked' > make[1]: *** [arch/x86/kernel/asm-offsets.s] Error 1 > make: *** [prepare0] Error 2 > > The fix is simple, and should be folded back into the rt-mutex-core.patch > Fix is attached. I saw this too, and was about to send a fix along with some other fixes I'd stumbled across. However, looking at the other arch implementations, I think the fix is different from what you've posted -- i.e. I think it should be simply this: -static inline int rwsem_is_locked(struct compat_rw_semaphore *sem) +static inline int compat_rwsem_is_locked(struct compat_rw_semaphore *sem) I'll get the actual patch for this and two other compile fixes sent along in a few minutes. Paul. -- To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
