Le 20 août 08 à 23:48, John Kacur a écrit :
I kind of find this confusing, because the return value is only useful
in one specific instance. In other cases, the return value is thrown
away. People who are not aware of the history of this code and examine
it later may ask why the return value is being ignored in some cases.
John,
I don't see anything confusing here. It's similar to a function where
you have plenty
of parameters and depending on the context, only a few are useful. In
the present
case, the timers mode names (...NOSOFTIRQ) speak for themselves. They
don't need
this return code.
As there is already plenty of explanations and comments within the code,
people 'not aware' will do as everbody else do: decrypt and
understand. ;-)
Anyway, I don't mind adding comments at the head of the function.
My goal here is only to make the code more readable and easier to
maintain by
factorization this is why I separated this patch from the fix.
If you look at the factorized code, you see the only difference is the
raisesoftirq stuff.
I thought it was worth doing it.
Gilles.--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
