Re: locking_selftest triggers WARN_ON by exceeding MAX_RWLOCK_DEPTH

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Fri, 20 Jun 2008, Josh Triplett wrote:
>
> However, CONFIG_DEBUG_LOCKING_API_SELFTESTS includes tests which
> intentionally use locks incorrectly, and in particular it locks without
> unlocking.  This quickly reaches the 5 lock limit.  AA_rlock locks twice
> without unlocking, AA_rsem locks twice more without unlocking, and
> ABBA_rlock locks twice more before it unlocks; this nests read locks six
> deep, triggering the WARN_ON.
>
> Given that CONFIG_DEBUG_LOCKING_API_SELFTESTS exists to use locks
> incorrectly, I don't think this necessarily needs fixing.  However,
> perhaps locking_selftest should print a big warning in advance if run
> without lockdep turned on, saying to expect locking-related
> warnings/bugs/panics?

Hmm, perhaps we should shoot up the limit if
CONFIG_DEBUG_LOCKING_API_SELFTESTS is turned on, otherwise it can do bad
things. I hit the warn on, but I don't know how robust it is once a reader
locking is above that limit. OTW, it may make the system unstable and it
is not recommend to keep the box running.

-- Steve

--
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [RT Stable]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]

  Powered by Linux