On Tue, 2008-02-26 at 00:00 +0100, Pavel Machek wrote: > Hi! > > > > > index c913d48..c24c53d 100644 > > > > --- a/kernel/sysctl.c > > > > +++ b/kernel/sysctl.c > > > > @@ -175,6 +175,10 @@ extern struct ctl_table inotify_table[]; > > > > int sysctl_legacy_va_layout; > > > > #endif > > > > > > > > +#ifdef CONFIG_RTLOCK_LATERAL_STEAL > > > > +extern int rtmutex_lateral_steal; > > > > +#endif > > > > + > > > > > > Try checkpatch. > > > > I have that as part of quilt refresh, and it returns: > > > > Your patch has no obvious style problems and is ready for > > submission. > > Sorry. Anyway, there should not be externs in .c files, so > > extern int rtmutex_lateral_steal; > > should go to header file. Just for the record: grep extern kernel/sysctl.c | wc -l 40 There is a whole slew here, that I agree could move elsewhere - maybe into sysctl.h? If no one objects, I'll make a patch to move them all? Sven > Pavel - To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
