>>> On Mon, Jan 14, 2008 at 3:27 AM, in message
<1200299260.4665.17.camel@xxxxxxxxxxxxxxxx>, Mike Galbraith <efault@xxxxxx>
wrote:
> On Sun, 2008-01-13 at 15:54 -0500, Steven Rostedt wrote:
>
>> OK, -rt2 will take a bit more beating from me before I release it, so it
>> might take some time to get it out (expect it out on Monday).
>
> Ah, that reminds me (tests, yup) I still need the patchlet below to
> resume from ram without black screen of death.
I had forgotten about this issue over the holidays...Sorry Mike.
So does that BUG_ON trip if you remove the first hunk?
> No idea why my P4 box
> seems to be the only box in the rt galaxy affected. (haven't poked at
> it since the holidays)
>
> Index: linux-2.6.24.git-rt1/kernel/sched_rt.c
> ===================================================================
> --- linux-2.6.24.git-rt1.orig/kernel/sched_rt.c
> +++ linux-2.6.24.git-rt1/kernel/sched_rt.c
> @@ -33,6 +33,9 @@ static inline void rt_clear_overload(str
>
> static void update_rt_migration(struct rq *rq)
> {
> + if (unlikely(num_online_cpus() == 1))
> + return;
> +
> if (rq->rt.rt_nr_migratory && (rq->rt.rt_nr_running > 1)) {
> if (!rq->rt.overloaded) {
> rt_set_overload(rq);
> @@ -105,8 +108,10 @@ static inline void dec_rt_tasks(struct t
> } /* otherwise leave rq->highest prio alone */
> } else
> rq->rt.highest_prio = MAX_RT_PRIO;
> - if (p->nr_cpus_allowed > 1)
> + if (p->nr_cpus_allowed > 1) {
> + BUG_ON(!rq->rt.rt_nr_migratory);
> rq->rt.rt_nr_migratory--;
> + }
>
> if (rq->rt.highest_prio != highest_prio)
> cpupri_set(&rq->rd->cpupri, rq->cpu, rq->rt.highest_prio);
>
>
> btw, CONFIG_INTEL_IOATDMA compile booboo
>
> CC drivers/dma/ioat_dma.o
> drivers/dma/ioat_dma.c: In function ‘ioat1_tx_submit’:
> drivers/dma/ioat_dma.c:300: error: too few arguments to function
> ‘__list_splice’
> make[2]: *** [drivers/dma/ioat_dma.o] Error 1
>
>
> -
> To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at http://vger.kernel.org/majordomo-info.html
-
To unsubscribe from this list: send the line "unsubscribe linux-rt-users" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
